[webkit-reviews] review granted: [Bug 75164] DFG does double-to-int conversion incorrectly when storing into int typed arrays : [Attachment 120440] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 23 06:29:41 PST 2011
Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 75164: DFG does double-to-int conversion incorrectly when storing into int
typed arrays
https://bugs.webkit.org/show_bug.cgi?id=75164
Attachment 120440: the patch
https://bugs.webkit.org/attachment.cgi?id=120440&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120440&action=review
r=me
> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:-806
> - // FIXME: Generate correct code for a double to unsigned conversion.
> - m_assembler.cvttsd2si_rr(src, dest);
Yikes!
More information about the webkit-reviews
mailing list