[webkit-reviews] review denied: [Bug 75166] Web Inspector: Implement a worker for parsing out JavaScript function data : [Attachment 120443] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 75166: Web Inspector: Implement a worker for parsing out JavaScript
function data
https://bugs.webkit.org/show_bug.cgi?id=75166

Attachment 120443: Patch
https://bugs.webkit.org/attachment.cgi?id=120443&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120443&action=review


> Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:68
> +    buildScriptOutline();

I think you should combine this worker with the one that formats source.

> Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:140
> +		   setTimeout(buildScriptOutline, 0);

You should not use setTimeout in worker.