[webkit-reviews] review denied: [Bug 73051] Implement navigator.startActivity for WebIntents : [Attachment 120415] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Greg Billock <gbillock at google.com>'s
request for review:
Bug 73051: Implement navigator.startActivity for WebIntents
https://bugs.webkit.org/show_bug.cgi?id=73051

Attachment 120415: Patch
https://bugs.webkit.org/attachment.cgi?id=120415&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120415&action=review


Anyway, this review is mixing together many issues because this patch is way
too large.  Please break the patch up in the small, reviewable pieces and we'll
cover these issues as we get to them.

> Source/WebCore/Modules/intents/IntentsController.cpp:53
> +    static Mutex lastUsedIntentIdMutex;
> +    MutexLocker locker(lastUsedIntentIdMutex);

We shouldn't have a mutex.  The DOM has only one thread.