[webkit-reviews] review granted: [Bug 73883] Give embedders a chance to handle postMessage calls : [Attachment 120411] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 22 17:03:16 PST 2011


Adam Barth <abarth at webkit.org> has granted Karl Koscher
<supersat at chromium.org>'s request for review:
Bug 73883: Give embedders a chance to handle postMessage calls
https://bugs.webkit.org/show_bug.cgi?id=73883

Attachment 120411: Patch
https://bugs.webkit.org/attachment.cgi?id=120411&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120411&action=review


> Source/WebCore/page/DOMWindow.cpp:919
> +    if
(m_frame->loader()->client()->willCheckAndDispatchMessageEvent(timer->targetOri
gin(), PassRefPtr<MessageEvent>(event).leakRef()))

Can m_frame be null here?  Perhaps we should check
isCurrentlyDisplayedInFrame() ?


More information about the webkit-reviews mailing list