[webkit-reviews] review canceled: [Bug 66521] TestWebKitAPI has issues due to FastMalloc incompatibility : [Attachment 120373] Patch v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 22 16:41:56 PST 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 66521: TestWebKitAPI has issues due to FastMalloc incompatibility
https://bugs.webkit.org/show_bug.cgi?id=66521

Attachment 120373: Patch v5
https://bugs.webkit.org/attachment.cgi?id=120373&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Clearing the review flag.

The way that the WebCore headers are referenced will cause Apple internal
builds to fail because WebCore.framework won't be at $(BUILT_PRODUCTS_DIR).  We
need to add a Production target to gtest to make it work, then redefine the
variable where the WebCore headers are searched for in that configuration.

I will do this for the next patch.


More information about the webkit-reviews mailing list