[webkit-reviews] review granted: [Bug 75141] ProcessingInstruction should not be a ContainerNode : [Attachment 120397] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 22 16:22:50 PST 2011


Darin Adler <darin at apple.com> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 75141: ProcessingInstruction should not be a ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=75141

Attachment 120397: Patch
https://bugs.webkit.org/attachment.cgi?id=120397&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This changes behavior. When you call appendChild on a ProcessingInstruction and
pass null for the child, you will get HIERARCHY_REQUEST_ERR now, and before you
would get NOT_FOUND_ERR. While unimportant, it would be nice to get this edge
case right. Could we add tests covering that behavior?


More information about the webkit-reviews mailing list