[webkit-reviews] review granted: [Bug 66509] [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation : [Attachment 120395] DumpRenderTree fixed

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 66509: [WebWorkers][Chromium] Remove remains of cross-process dedicated
worker implementation
https://bugs.webkit.org/show_bug.cgi?id=66509

Attachment 120395: DumpRenderTree fixed
https://bugs.webkit.org/attachment.cgi?id=120395&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120395&action=review


> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:45
> +

No need for blank line here.

> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:55
> +

No need for blank line here. (Just sort all of these together.)

> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:59
> +#include <wtf/MainThread.h>

<wtf/... should be after other header includes.

> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:61
>  #include "WorkerDebuggerAgent.h"

Should be with the other #include's.

> Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:162
> +						
PassOwnPtr<MessagePortChannelArray> channels)

indent off. (in many places in this file).