[webkit-reviews] review granted: [Bug 75114] Refactored String.prototype.replace : [Attachment 120368] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 75114: Refactored String.prototype.replace
https://bugs.webkit.org/show_bug.cgi?id=75114

Attachment 120368: Patch
https://bugs.webkit.org/attachment.cgi?id=120368&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120368&action=review


> Source/JavaScriptCore/ChangeLog:15
> +	   * runtime/JSString.h: Removed the single-character case because it's
no
> +	   different from the normal case. (If we do come up with a
single-character
> +	   optimization in future, it probably doesn't belong in JSString,
anyway.)

What do you mean by no different from the normal case? Isn’t the find for a
single character a different, faster function?