[webkit-reviews] review granted: [Bug 74260] SnowLeopard crashes due to thread-unsafe EventListenerIterator ASSERTs : [Attachment 120328] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 74260: SnowLeopard crashes due to thread-unsafe EventListenerIterator
ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=74260

Attachment 120328: Patch
https://bugs.webkit.org/attachment.cgi?id=120328&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120328&action=review


> Source/WebCore/dom/EventListenerMap.h:85
> +#ifdef NDEBUG
> +    void assertNoActiveIterators() { }
> +#else
> +    void assertNoActiveIterators();

Sometimes I like to put the declaration in unconditionally and put the inline
empty implementation outside the class definition.

> Source/WebCore/dom/EventListenerMap.h:87
> +    Mutex m_activeIteratorCountMutex;

Since this is for assertion purposes only, we could consider just sharing one
global mutex rather than having a separate one for each map. That could keep
down the number of #if statements in the header.