[webkit-reviews] review granted: [Bug 75085] Web Inspector: TabbedPane should support closeable tabs, hiding tabs into drop down menu. : [Attachment 120320] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 75085: Web Inspector: TabbedPane should support closeable tabs, hiding tabs
into drop down menu.
https://bugs.webkit.org/show_bug.cgi?id=75085

Attachment 120320: Patch
https://bugs.webkit.org/attachment.cgi?id=120320&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120320&action=review


> Source/WebCore/inspector/front-end/TabbedPane.js:37
> +WebInspector.TabbedPane = function(shrinkableTabs, closeableTabs)

Since you don't use these values in the constructor, prefer setShrinkableTabs
and setCloseableTabs (or use the setters notation).

> Source/WebCore/inspector/front-end/inspector.css:1732
> +.tabbed-pane-header .tabbed-pane-header-tab-title {

Unless tabbed pane stops being a View, please place these into a lazily loaded
tabbedPane.css.

> LayoutTests/inspector/tabbed-pane-tabs-to-show.html:38
> +    testWidthsAndHistory([50, 50, 60, 60, 70, 70], [0, 1, 2, 3, 4, 5], 370);


Too much copy-paste?