[webkit-reviews] review granted: [Bug 74900] Change the build flow of AppleWebKit to use the [Supplemental] IDL : [Attachment 120254] WIP patch to see if build passes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 21 23:15:39 PST 2011


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 74900: Change the build flow of AppleWebKit to use the [Supplemental] IDL
https://bugs.webkit.org/show_bug.cgi?id=74900

Attachment 120254: WIP patch to see if build passes
https://bugs.webkit.org/attachment.cgi?id=120254&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120254&action=review


I'm marking this R+, but I'm slightly unsure that we'll re-build JSDOMWindow.h
when DOMWindowWebSocket.idl changes.

> Source/WebCore/ChangeLog:24
> +		   generate-bindings.pl depends on $idl and
supplemental_dependency.tmp;

Will this step correctly run if only the supplemental IDL file is changed?


More information about the webkit-reviews mailing list