[webkit-reviews] review requested: [Bug 74995] [EFL][WK2] Implement context menu for EFL port : [Attachment 120149] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has asked  for review:
Bug 74995: [EFL][WK2] Implement context menu for EFL port
https://bugs.webkit.org/show_bug.cgi?id=74995

Attachment 120149: Patch
https://bugs.webkit.org/attachment.cgi?id=120149&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120149&action=review


> Source/WebCore/platform/efl/ContextMenuItemEfl.cpp:103
>  void ContextMenuItem::setChecked(bool)
>  {
> -    notImplemented();
> +    m_platformDescription.checked = checked;

Shouldn't this use the argument?

> Source/WebCore/platform/efl/ContextMenuItemEfl.cpp:114
>  void ContextMenuItem::setEnabled(bool)
>  {
> -    notImplemented();
> +    m_platformDescription.enabled = enabled;
>  }

Ditto.