[webkit-reviews] review granted: [Bug 75027] AX: Title attribute should not be used in AXTitle : [Attachment 120225] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 75027: AX: Title attribute should not be used in AXTitle
https://bugs.webkit.org/show_bug.cgi?id=75027

Attachment 120225: patch
https://bugs.webkit.org/attachment.cgi?id=120225&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120225&action=review


> Source/WebCore/accessibility/AccessibilityTableCell.h:60
> +    // if a table cell is not exposed as a table cell, a TH element can
> +    // serve as its title ui element

We use sentence style in WebKit comments.

    // If a table cell is not exposed as a table cell, a TH element can serve
as its title UI element.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1690
> +	   return hasTextAlternative() ? true : false;

There is no need to say "? true : false".