[webkit-reviews] review granted: [Bug 62813] [filesystem] Remove old filesystem naming restrictions : [Attachment 120195] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 62813: [filesystem] Remove old filesystem naming restrictions
https://bugs.webkit.org/show_bug.cgi?id=62813

Attachment 120195: Patch
https://bugs.webkit.org/attachment.cgi?id=120195&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120195&action=review


>>> Source/WebCore/ChangeLog:8
>>> +	     No new tests. (OOPS!)
>> 
>> This statement is false. :)
> 
> Well, modifications of existing tests, I suppose.  OOPS! indeed.  ;'>

Just remove it and put in the correct statement.

> Source/WebCore/fileapi/DOMFilePath.cpp:122
> +    // Embedded NULs are not allowed.

NUL? Embedbed \0 are not allowed.

> Source/WebCore/fileapi/DOMFilePath.cpp:123
> +    if (path.find((UChar)0) != WTF::notFound)

Use c++ style casts. Or why not just do '\0'?