[webkit-reviews] review requested: [Bug 74952] Need AssociatedURLLoader tests for redirects and CORS access control : [Attachment 120221] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 21 14:48:15 PST 2011


Bill Budge <bbudge at gmail.com> has asked  for review:
Bug 74952: Need AssociatedURLLoader tests for redirects and CORS access control
https://bugs.webkit.org/show_bug.cgi?id=74952

Attachment 120221: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=120221&action=review

------- Additional Comments from Bill Budge <bbudge at gmail.com>
Adam, it turns out it's easier to leave that check in than to add the comment.
So I put it back in.

My thinking was that there are a lot of properties I can check on the
responses, but since they're created by the test code (mocks) and passed
unchanged by the loader framework, it's just testing the test code.

Thanks for reviewing this!


More information about the webkit-reviews mailing list