[webkit-reviews] review denied: [Bug 66062] <select> popup menu appears in wrong place when page is zoomed : [Attachment 106881] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 66062: <select> popup menu appears in wrong place when page is zoomed
https://bugs.webkit.org/show_bug.cgi?id=66062

Attachment 106881: Patch
https://bugs.webkit.org/attachment.cgi?id=106881&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106881&action=review


> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:639
> -    return padding;
> +    return padding * frame()->pageScaleFactor();

Really?  I thought we applied the pageScaleFactor at only a very few high-level
places?  Are you sure all these low-level rendering objects need to know about
it?   If so, how do we find all the places it's needed?