[webkit-reviews] review denied: [Bug 73753] Move shouldLayoutFixedElementsRelativeToFrame to Page.cpp : [Attachment 117772] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 73753: Move shouldLayoutFixedElementsRelativeToFrame to Page.cpp
https://bugs.webkit.org/show_bug.cgi?id=73753

Attachment 117772: Patch
https://bugs.webkit.org/attachment.cgi?id=117772&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117772&action=review


Seems reasonable to me, but loks like the EWS bots strongly disagree.  Please
upload a new patch which passes EWS. :)

> Source/WebCore/ChangeLog:10
> +	   of frame because it's a no-op on subframes. This is a page-level
property. To
> +	   reduce confusion and to save a few bytes, it has been moved to Page.


Bytes don't really matter on FrameView. :)