[webkit-reviews] review granted: [Bug 75028] Inform the scrolling coordinator when scrollbar layers come and go : [Attachment 120212] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 75028: Inform the scrolling coordinator when scrollbar layers come and go
https://bugs.webkit.org/show_bug.cgi?id=75028

Attachment 120212: Patch
https://bugs.webkit.org/attachment.cgi?id=120212&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120212&action=review


> Source/WebCore/page/ScrollingCoordinator.h:63
> +    void setFrameViewHorizontalScrollbarLayer(FrameView*, const
GraphicsLayer* horizontalScrollbarLayer);

The second argument name is hardly needed here.

> Source/WebCore/page/ScrollingCoordinator.h:66
> +    void setFrameViewVerticalScrollbarLayer(FrameView*, const GraphicsLayer*
verticalScrollbarLayer);

Ditto.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1725
> +	       if (ScrollingCoordinator* scrollingCoordinator =
this->scrollingCoordinator())
> +		  
scrollingCoordinator->setFrameViewHorizontalScrollbarLayer(m_renderView->frameV
iew(), 0);

Wrong indentation here.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1750
> +	       if (ScrollingCoordinator* scrollingCoordinator =
this->scrollingCoordinator())
> +		  
scrollingCoordinator->setFrameViewVerticalScrollbarLayer(m_renderView->frameVie
w(), 0);

Ditto.