[webkit-reviews] review granted: [Bug 74840] [CSS Shaders] Follow up bug to fix issues mentioned in comment 23 from bug 73317 : [Attachment 120018] Patch V2

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 74840: [CSS Shaders] Follow up bug to fix issues mentioned in comment 23
from bug 73317
https://bugs.webkit.org/show_bug.cgi?id=74840

Attachment 120018: Patch V2
https://bugs.webkit.org/attachment.cgi?id=120018&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120018&action=review


Much nicer, thanks a lot. r=me with a few comments:

> Source/WebCore/platform/graphics/filters/CustomFilterShader.cpp:51
> +const char* CustomFilterShader::defaultFragmentShaderString =
> +	   "precision mediump float;\n" \

I admit, I like the other solution much more now :-)
It's much more readable, would you mind updating it once again?

> Source/WebCore/platform/graphics/filters/CustomFilterShader.h:79
> +    static const char* defaultVertexShaderString;
> +    static const char* defaultFragmentShaderString;

This could be removed again using this SHADER technique.