[webkit-reviews] review granted: [Bug 74981] Extract BlackBerry CMake arguments from build-webkit into separate function : [Attachment 120198] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 74981: Extract BlackBerry CMake arguments from build-webkit into separate
function
https://bugs.webkit.org/show_bug.cgi?id=74981

Attachment 120198: Patch
https://bugs.webkit.org/attachment.cgi?id=120198&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120198&action=review


Looks good.

> Tools/Scripts/webkitdirs.pm:932
> +    push @cxxFlags, "-Wl,-rpath-link," . File::Spec->catfile($stageUsrLib,
"torch-webkit");

We do not have the torch-webkit directory anymore, this needs to be removed in
a follow-up patch.