[webkit-reviews] review denied: [Bug 74991] Automate elements' registration as document namedItem/extraNamedItem. : [Attachment 120140] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied  review:
Bug 74991: Automate elements' registration as document
namedItem/extraNamedItem.
https://bugs.webkit.org/show_bug.cgi?id=74991

Attachment 120140: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=120140&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=120140&action=review


r- for now for perf concern.

> Source/WebCore/html/HTMLElement.cpp:1005
> +void HTMLElement::insertedIntoDocument()
> +{
> +    StyledElement::insertedIntoDocument();
> +
> +    const AtomicString& name = fastGetAttribute(HTMLNames::nameAttr);
> +    if (!name.isNull())
> +	   updateName(nullAtom, name);
> +}

Hmm, adding attribute lookup here might be slow. Is there a way to avoid this?