[webkit-reviews] review requested: [Bug 74983] Extract WinCE CMake arguments from build-webkit into separate function : [Attachment 120193] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 21 10:33:50 PST 2011
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 74983: Extract WinCE CMake arguments from build-webkit into separate
function
https://bugs.webkit.org/show_bug.cgi?id=74983
Attachment 120193: Patch
https://bugs.webkit.org/attachment.cgi?id=120193&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
Added function webkitdirs::cmakeBasedPortArguments() and moved WinCE-specific
CMake arguments into it. Also, use cmakeBasedPortArguments() when constructing
the the list of CMake arguments for the EFL port. Currently,
cmakeBasedPortArguments() returns the empty list for the EFL port.
More information about the webkit-reviews
mailing list