[webkit-reviews] review granted: [Bug 75005] Web Inspector: TabbedPane should use tabElement width measuring to layout tab elements when width is too small to fit them. : [Attachment 120172] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 21 05:55:31 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 75005: Web Inspector: TabbedPane should use tabElement width measuring to
layout tab elements when width is too small to fit them.
https://bugs.webkit.org/show_bug.cgi?id=75005

Attachment 120172: Patch
https://bugs.webkit.org/attachment.cgi?id=120172&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120172&action=review


> Source/WebCore/inspector/front-end/TabbedPane.js:85
> +	   this._maybeMeasureAndUpdate();

onResize is anyways getting called.

> Source/WebCore/inspector/front-end/TabbedPane.js:150
> +	   for (var i = measuredWidths.length - 1; i > 0; i--) {

--i


More information about the webkit-reviews mailing list