[webkit-reviews] review granted: [Bug 74601] [Qt][WK2] Pinch zoom should affect the page size : [Attachment 120023] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 21 04:02:16 PST 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 74601: [Qt][WK2] Pinch zoom should affect the page size
https://bugs.webkit.org/show_bug.cgi?id=74601

Attachment 120023: proposed patch
https://bugs.webkit.org/attachment.cgi?id=120023&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120023&action=review


Maybe simon has comments

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1002
> +    if (ev->type() == QEvent::InputMethod)
> +	   return false; // This is necessary to avoid an endless loop in
connection with QQuickItem::event().

What about looking into this? :) *hint*

> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:162
> +    lastPos = webPagePoint;

webContentPoint?


More information about the webkit-reviews mailing list