[webkit-reviews] review granted: [Bug 71705] CSS 2.1 failure: border-collapse-offset-002.htm fails : [Attachment 120005] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 71705: CSS 2.1 failure: border-collapse-offset-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=71705

Attachment 120005: Patch
https://bugs.webkit.org/attachment.cgi?id=120005&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120005&action=review


Too bad your change confuses the EWS. The previous changes passed the EWS so I
am inclined to trust this patch is as good.

> Source/WebCore/rendering/RenderTable.cpp:120
> +	   m_captions.append(toRenderTableCaption(child));

There are several other callsites in RenderTable.cpp that are checking:

child->isRenderBlock() && child->style()->display() == TABLE_CAPTION

They should be modified too. There is also one in RenderTheme.cpp that should
be patched.

> Source/WebCore/rendering/RenderTableCaption.h:34
> +    virtual LayoutUnit containingBlockLogicalWidthForContent() const;
> +    
> +private:
> +    virtual bool isTableCaption() const { return true; }

You should use the new OVERRIDE keyword for those 2 functions.

> Source/WebCore/rendering/RenderTableCaption.h:43
> +inline const RenderTableCaption* toRenderTableCaption(const RenderObject*
object)

Nit: inline is not needed here as anything in a header is inlined by default.
That said better to be sure sometimes.