[webkit-reviews] review granted: [Bug 74992] In prepare-ChangeLog, replace constant global variables with "use constant" : [Attachment 120141] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 74992: In prepare-ChangeLog, replace constant global variables with "use
constant"
https://bugs.webkit.org/show_bug.cgi?id=74992

Attachment 120141: Patch
https://bugs.webkit.org/attachment.cgi?id=120141&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120141&action=review


Looks sane to me.

> Tools/Scripts/prepare-ChangeLog:320
> +    my $command = GIT . " log --max-count=1 --pretty=\"format:%an\"
\"$gitCommit\"";

Why don't we use single quotations here?