[webkit-reviews] review granted: [Bug 74863] Web Inspector: Add CSSStyleSelector instrumentation calls towards implementing a CSS selector profiler : [Attachment 120006] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 74863: Web Inspector: Add CSSStyleSelector instrumentation calls towards
implementing a CSS selector profiler
https://bugs.webkit.org/show_bug.cgi?id=74863

Attachment 120006: Patch
https://bugs.webkit.org/attachment.cgi?id=120006&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=120006&action=review


r=me, with some comments

> Source/WebCore/css/CSSStyleSelector.cpp:725
> +	   InspectorInstrumentationCookie cookie;
> +#if ENABLE(INSPECTOR)
> +	   if (InspectorInstrumentation::hasFrontends())
> +	       cookie = InspectorInstrumentation::willMatchRule(document(),
rule);
> +#endif

It would be cleaner to inline the front end and enable checks inside the
InspectorInstrumentation call. Returning a null cookie probably doesn't have
meaningful cost.

> Source/WebCore/css/CSSStyleSelector.cpp:2187
> +    InspectorInstrumentationCookie cookie;
> +#if ENABLE(INSPECTOR)
> +    if (InspectorInstrumentation::hasFrontends())
> +	   cookie = InspectorInstrumentation::willProcessRule(document(),
styleDeclaration->parentRule());
> +#endif

Same comment as above.