[webkit-reviews] review granted: [Bug 73350] [chromium] Allow scrolling non-root layers in the compositor thread : [Attachment 120067] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Sami Kyostila
<skyostil at google.com>'s request for review:
Bug 73350: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Attachment 120067: Patch
https://bugs.webkit.org/attachment.cgi?id=120067&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Looks good, R=me.

This looks like a really good use case for the layer tree iterators underway
here: https://bugs.webkit.org/show_bug.cgi?id=74203.  Sami, when you get a
chance could you add some unit tests for the hit testing order in various cases
(no render surfaces, render surfaces that overlap, backface of single-sided,
etc) so that we can transition the collect*Layers() logic over to using
iterators with confidence that we aren't regressing behavior?

Set cq? when this is ready to land and myself or any committer can mark it cq+.
 I'm not sure if there are conflicts or overlaps with other patches, so I'm not
setting it now.