[webkit-reviews] review denied: [Bug 74974] [Coverity] removed dead code : [Attachment 120115] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 20 17:04:25 PST 2011


James Robinson <jamesr at chromium.org> has denied Rachel Blum
<groby at chromium.org>'s request for review:
Bug 74974: [Coverity] removed dead code
https://bugs.webkit.org/show_bug.cgi?id=74974

Attachment 120115: Patch
https://bugs.webkit.org/attachment.cgi?id=120115&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120115&action=review


I am significantly skeptical of the correctness of this patch. What's the
reasoning behind it?

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

this will fail an SVN presubmit check


More information about the webkit-reviews mailing list