[webkit-reviews] review denied: [Bug 71263] Report correct line number for non-native editable text elements. : [Attachment 119975] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 71263: Report correct line number for non-native editable text elements.
https://bugs.webkit.org/show_bug.cgi?id=71263

Attachment 119975: Patch
https://bugs.webkit.org/attachment.cgi?id=119975&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119975&action=review


> Source/WebCore/accessibility/AXObjectCache.cpp:678
> +    for (; element && !element->hasTagName(bodyTag); element =
element->parentElement()) {

It's not okay to stop the search at body. We can have a style rule like "head {
display: block; }" with aria roles specified on elements inside head.