[webkit-reviews] review denied: [Bug 63558] Media element loads blocked by a resource load delegate or beforeload handler do not generate an error event : [Attachment 120072] Changes based on Eric's suggestions.

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Shadi <shadi at chromium.org>'s
request for review:
Bug 63558: Media element loads blocked by a resource load delegate or
beforeload handler do not generate an error event
https://bugs.webkit.org/show_bug.cgi?id=63558

Attachment 120072: Changes based on Eric's suggestions.
https://bugs.webkit.org/attachment.cgi?id=120072&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120072&action=review


> LayoutTests/media/media-blocked-by-beforeload.html:35
> +	       if (loadedFired)
> +		   checkEndTest();

Where is "checkEndTest"? What is it supposed to do?

> LayoutTests/media/media-blocked-by-beforeload.html:112
> +	       if (loadedmetadataFired)
> +		  endTest();

Isn't the theory that that we can't predict the order that 'load' and
'loadedmetadata' will fire? If so, the results will have
"EVENT('loadedmetadata')" when 'loadedmetadata' first first, but not if 'load'
first first.