[webkit-reviews] review denied: [Bug 74757] XSLT-created HTML documents do not inherit first party for cookies from originally loaded XML. : [Attachment 120085] Patch, test, whitespace cleanup.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Thomas Sepez
<tsepez at chromium.org>'s request for review:
Bug 74757: XSLT-created HTML documents do not inherit first party for cookies
from originally loaded XML.
https://bugs.webkit.org/show_bug.cgi?id=74757

Attachment 120085: Patch, test, whitespace cleanup.
https://bugs.webkit.org/attachment.cgi?id=120085&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
One important thing about "firstPartyForCookies" related names in Document is
that they are a result of misunderstanding. They are used for more than
cookies. An example that I recently discovered is that the same data is used
when setting quarantine metadata on downloaded files.

The original name was "mainDocumentURL", which matches the behavior much
better. Conceptually, it's what the user thinks the URL they are viewing is
(and users cannot see subframe URLs and such). In fact, that was the original
name in WebCore.

The refactoring here seems harmless. However, I would suggest to fix the names
and comments before doing any refactoring - that would make the intentions much
clearer.

I'm marking this r- for procedural reasons, although the patch itself appears
quite good. There has been much confusion over this before, so ideally, there
should be three patches, one to fix the bug, one to rename
firstPartyForCookies, and one to do the refactoring that Adam suggested.