[webkit-reviews] review granted: [Bug 74963] Don't crash on the second time VideoLayerChromium::createCCVideoLayer() is called : [Attachment 120095] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 20 15:10:14 PST 2011
James Robinson <jamesr at chromium.org> has granted Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 74963: Don't crash on the second time
VideoLayerChromium::createCCVideoLayer() is called
https://bugs.webkit.org/show_bug.cgi?id=74963
Attachment 120095: Patch
https://bugs.webkit.org/attachment.cgi?id=120095&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120095&action=review
> Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h:59
> + VideoFrameProvider* m_provider;
would you mind adding a comment here indicating that this class should never
dereference this pointer, but simply pass it on to the CCVideoLayerImpl ?
More information about the webkit-reviews
mailing list