[webkit-reviews] review granted: [Bug 74876] sizeof(RenderStyle) is 64 instead of 56 on Windows (x86) : [Attachment 120045] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 74876: sizeof(RenderStyle) is 64 instead of 56 on Windows (x86)
https://bugs.webkit.org/show_bug.cgi?id=74876

Attachment 120045: Patch
https://bugs.webkit.org/attachment.cgi?id=120045&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120045&action=review


>> Source/WebCore/rendering/style/RenderStyle.h:169
>> +	    void setExplicitInheritance(bool value) { m_explicitInheritance =
value; }
> 
> Can we generate these with a macro? Also, since all these variables are only
used within getters and setters, it might make more sense to make those getters
and setters friends of this class instead.

Apparently we can't do this since RenderStyle hadn't be fully declared yet.