[webkit-reviews] review granted: [Bug 69762] Improper handling of foreignobjects nested in svg groups : [Attachment 113671] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Florin Malita <fmalita at google.com>'s
request for review:
Bug 69762: Improper handling of foreignobjects nested in svg groups
https://bugs.webkit.org/show_bug.cgi?id=69762

Attachment 113671: Patch
https://bugs.webkit.org/attachment.cgi?id=113671&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=113671&action=review


Thank you for the fix.

>>>
LayoutTests/platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.t
xt:5
>>>	 RenderSVGForeignObject {foreignObject} at (10,10) size 480x360
>> 
>> This change seems reasonable, but these values still seem a little strange. 
 Is the FO really bigger than the SVG Root?
> 
> 

It just looks like the FO is being clipped by the svg root, given those origin
values.  Or is the FO's origin relative to the SVG (actually, come to think of
it, I think it is).