[webkit-reviews] review denied: [Bug 73533] Upstream the multipart feature in blackberry port : [Attachment 119979] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 20 12:58:18 PST 2011
Rob Buis <rwlbuis at gmail.com> has denied Chris.Guan
<chris.guan at torchmobile.com.cn>'s request for review:
Bug 73533: Upstream the multipart feature in blackberry port
https://bugs.webkit.org/show_bug.cgi?id=73533
Attachment 119979: Patch
https://bugs.webkit.org/attachment.cgi?id=119979&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119979&action=review
Looks good, some variable names need to be fixed though.
> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:341
> + bool needsAdd = true;
Can you come up with a clearer name?
> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:342
> + int replaceHedearIndex = 0;
I think replaceHeaderIndex is meant here.
More information about the webkit-reviews
mailing list