[webkit-reviews] review denied: [Bug 74932] [Qt][WK2] Add ArgumentCoder functions for size_t. : [Attachment 120035] patch for review.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 74932: [Qt][WK2] Add ArgumentCoder functions for size_t.
https://bugs.webkit.org/show_bug.cgi?id=74932

Attachment 120035: patch for review.
https://bugs.webkit.org/attachment.cgi?id=120035&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120035&action=review


> Source/WebKit2/Shared/qt/ArgumentCodersQt.cpp:100
> +#if WTF_USE_JSVALUE64

That doesn't sound like the right macro to use. Technically it refers to an
implementation detail of JSC.

I also think uintptr_t is a better type to use than size_t, and with a bit of
template specialization you should be able to figure out the size of uintptr_t,
instead of using the macro.

I see what you're trying to use this for, but I don't think it's the right
thing to do. I'll comment on the other bug about the use-case.