[webkit-reviews] review denied: [Bug 74859] [Qt] WK2 Debugging quirks need some improvement : [Attachment 119871] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 74859: [Qt] WK2 Debugging quirks need some improvement
https://bugs.webkit.org/show_bug.cgi?id=74859

Attachment 119871: Patch
https://bugs.webkit.org/attachment.cgi?id=119871&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119871&action=review


> Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:92
> -    if (getenv("QT_WEBKIT_KEEP_ALIVE_WEB_PROCESS"))
> +    if (qgetenv("QT_WEBKIT2_DEBUG") == QByteArray("1"))

It is faster to just write

    if (qgetenv("QT_WEBKIT2_DEBUG") == "1")

and avoid the temporary QByteArray (with its malloc). qbytearray.h defines

inline bool operator==(const QByteArray &a1, const char *a2)

> Tools/WebKitTestRunner/qt/TestControllerQt.cpp:114
> +void TestController::platformRunUntil(bool& done, double timeout)
>  {
> +    if (qgetenv("QT_WEBKIT2_DEBUG") == QByteArray("1")) {
> +	   // Never timeout if we are debugging.
> +	   TestControllerRunLoop::instance()->startWithCondition(done);
> +	   return;
> +    }
> +

This code needs to be adapted to the removal of TestControllerRunLoop :)