[webkit-reviews] review granted: [Bug 74633] Allow JSStaticScope to bind more than one variable : [Attachment 119482] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Andy Wingo
<wingo at igalia.com>'s request for review:
Bug 74633: Allow JSStaticScope to bind more than one variable
https://bugs.webkit.org/show_bug.cgi?id=74633

Attachment 119482: Patch
https://bugs.webkit.org/attachment.cgi?id=119482&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
So, we're really keen to avoid unnecessary complexity introduced by premature
optimizations, and I think this patch is probably not truly necessary at this
stage.	I think it would be perfectly possible to implement block scoped const
by pushing multiple consts each with their own scope.  Clearly letting them
share a scope object is more efficient, but it seems this is just an
optimization.  As such it would have been much better to implement the feature
first, then the optimization for it, rather than implementing an optimization
for a feature that doesn't just exist, and as such we can't assess the value
of!

I think it's likely enough that this will be a benefit in the long run that we
can let this slide this time, so I won't make you restructure your set of
changes to land this after block scoped const, but for future reference we
really do want changes like this to be justified empirically.