[webkit-reviews] review denied: [Bug 74882] implement layout tests for <video> with media stream : [Attachment 119919] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied wjia at chromium.org's request for
review:
Bug 74882: implement layout tests for <video> with media stream
https://bugs.webkit.org/show_bug.cgi?id=74882

Attachment 119919: Patch
https://bugs.webkit.org/attachment.cgi?id=119919&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119919&action=review


> Tools/DumpRenderTree/chromium/TestMediaStreamClient.cpp:38
> +#include "media/base/message_loop_factory.h"
> +#include "media/base/pipeline.h"
> +#include "media/video/capture/fake_capture_video_decoder.h"

We have to avoid using Chromium code other than webkit/support/ in DRT.

> Tools/DumpRenderTree/chromium/TestMediaStreamClient.cpp:46
> +namespace {
> +
> +static const int kVideoCaptureWidth = 352;
> +static const int kVideoCaptureHeight = 288;
> +static const int kVideoCaptureFramePerSecond = 30;
> +
> +} // namespace

Do not use anonymous namespace and k-prefix in WebKit code.

> Tools/DumpRenderTree/chromium/TestMediaStreamClient.h:38
> +#include "webkit/media/media_stream_client.h"

We have to avoid using Chromium code other than webkit/support/ in DRT.