[webkit-reviews] review denied: [Bug 74769] [chromium] Add CCTimer class for the compositor : [Attachment 119702] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 19 16:45:56 PST 2011


James Robinson <jamesr at chromium.org> has denied Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 74769: [chromium] Add CCTimer class for the compositor
https://bugs.webkit.org/show_bug.cgi?id=74769

Attachment 119702: Patch
https://bugs.webkit.org/attachment.cgi?id=119702&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Can you fix the tab issue?

This appears to be copy-pasting a fair amount of boilerplate, not all of which
is really relevant for our use cases. For example I don't think we have any
need for repeating timers or for passing a CCTimer* to the timer fired
callback. Let's start with the API that we need and the implementation we need
to support that interface alone.


More information about the webkit-reviews mailing list