[webkit-reviews] review granted: [Bug 74896] webkitpy: remove port.executive, port.filesystem, port.user properties : [Attachment 119936] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 74896: webkitpy: remove port.executive, port.filesystem, port.user
properties
https://bugs.webkit.org/show_bug.cgi?id=74896

Attachment 119936: Patch
https://bugs.webkit.org/attachment.cgi?id=119936&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119936&action=review


OK.  I'm surprised the diff is this small.

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:43
> -	   build_type = port.options.configuration.lower()
> +	   build_type = port.get_option('configuration').lower()

I think the previous version was cleaner.  Certainly for testing code where
we're not trying to have dynamic support for different option configurations.