[webkit-reviews] review denied: [Bug 68969] need iframe shim support for Gtk webkit : [Attachment 111723] iframe shims support in Gtk webkit.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 19 14:02:29 PST 2011
Eric Seidel <eric at webkit.org> has denied jane.xia2009 at gmail.com's request for
review:
Bug 68969: need iframe shim support for Gtk webkit
https://bugs.webkit.org/show_bug.cgi?id=68969
Attachment 111723: iframe shims support in Gtk webkit.
https://bugs.webkit.org/attachment.cgi?id=111723&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111723&action=review
> Source/WebCore/ChangeLog:8
> + Amend PluginViewGtk use IFframeShimSupport.h and
IFframeShimSupport.cpp to handle shims correctly.
IFframe?
> Source/WebCore/GNUmakefile.list.am:4086
> + Source/WebCore/plugins/IFrameShimSupport.cpp \
> + Source/WebCore/plugins/IFrameShimSupport.h
Are these new files? If so, they're missing from your patch.
More information about the webkit-reviews
mailing list