[webkit-reviews] review denied: [Bug 68876] Input element created at later stage(may be after page load) should not be auto focused. : [Attachment 109447] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 19 14:00:42 PST 2011


Eric Seidel <eric at webkit.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 68876: Input element created at later stage(may be after page load) should
not be auto focused.
https://bugs.webkit.org/show_bug.cgi?id=68876

Attachment 109447: Updated patch
https://bugs.webkit.org/attachment.cgi?id=109447&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109447&action=review


> LayoutTests/fast/forms/autofocus-add-autofocus-element-expected.txt:5
> +This input element should not have active state: 
> +
> +
> +PASS document.activeElement is document.getElementById("input")

These lines seem incongruous.

> LayoutTests/fast/forms/autofocus-opera-004-expected.txt:1
> -The form control should have a green background: 
> +The form control should have a red background: 

Red is normally an indication of failure in tests...


More information about the webkit-reviews mailing list