[webkit-reviews] review granted: [Bug 74562] webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects : [Attachment 119546] update w/ review feedback

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 74562: webkitpy: update unit tests in preparation for making host a
mandatory parameter to Port objects
https://bugs.webkit.org/show_bug.cgi?id=74562

Attachment 119546: update w/ review feedback
https://bugs.webkit.org/attachment.cgi?id=119546&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119546&action=review


Seems OK.  I'm not sure the TestWebKitPort change is a win.

> Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py:55
> +	   return Port(host, executive=executive, **kwargs)

This executive=executive isn't needed, right?

> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:-50
> -	   host = host or MockHost()
> -	   WebKitPort.__init__(self, host=host, **kwargs)

Interesting.  I thought  this "implicit MockHost" was useful.