[webkit-reviews] review granted: [Bug 72738] [chromium] Accelerated canvas broken in threaded compositing mode : [Attachment 119863] Rebased

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Iain Merrick
<husky at google.com>'s request for review:
Bug 72738: [chromium] Accelerated canvas broken in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=72738

Attachment 119863: Rebased
https://bugs.webkit.org/attachment.cgi?id=119863&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119863&action=review


Looks OK. Set cq? when you want this to land.

> Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.cpp:-68
> -    canvasLayer->setTextureId(textureId());
> -    canvasLayer->setHasAlpha(m_hasAlpha);
> -    canvasLayer->setPremultipliedAlpha(m_premultipliedAlpha);
> -}

this would have been much cleaner if you had left this function alone, made the
textureId() getter virtual, and provided appropriate overrides in
WebGLLayerChromium and Canvas2DLayerChromium