[webkit-reviews] review granted: [Bug 74834] Update dropzone implementation per spec update : [Attachment 119858] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 19 10:25:17 PST 2011


Tony Chang <tony at chromium.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 74834: Update dropzone implementation per spec update
https://bugs.webkit.org/show_bug.cgi?id=74834

Attachment 119858: Patch.
https://bugs.webkit.org/attachment.cgi?id=119858&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119858&action=review


> Source/WebCore/dom/Clipboard.cpp:213
> +    if (keyword.length() > 5 && keyword.startsWith("file:"))

Nit: startsWith will check the length for you so you can remove the length() >
5 check.

> Source/WebCore/dom/Clipboard.cpp:216
> +    if (keyword.length() > 7 && keyword.startsWith("string:"))

Remove the length() > 7 check.


More information about the webkit-reviews mailing list