[webkit-reviews] review granted: [Bug 74841] Move WebAudio and WebSocket getters from JSDOMWindowCustom.cpp to JSDOMWindow{WebAudio, WebSocket}Custom.cpp : [Attachment 119835] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 19 09:07:31 PST 2011


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 74841: Move WebAudio and WebSocket getters from JSDOMWindowCustom.cpp to
JSDOMWindow{WebAudio,WebSocket}Custom.cpp
https://bugs.webkit.org/show_bug.cgi?id=74841

Attachment 119835: Patch
https://bugs.webkit.org/attachment.cgi?id=119835&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119835&action=review


Ok.

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:598
> +// FIXME(haraken): This method will be removed, after all build systems
support

Usually WebKit skips the (haraken) part.


More information about the webkit-reviews mailing list