[webkit-reviews] review granted: [Bug 74603] Web Inspector: Implement CSS selector profiler backend : [Attachment 119859] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 74603: Web Inspector: Implement CSS selector profiler backend
https://bugs.webkit.org/show_bug.cgi?id=74603

Attachment 119859: Patch
https://bugs.webkit.org/attachment.cgi?id=119859&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119859&action=review


> Source/WebCore/inspector/InspectorCSSAgent.cpp:332
> +    if (m_state->getBoolean(CSSAgentState::isSelectorProfiling))

This will not work.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:583
> +    if (m_state->getBoolean(CSSAgentState::isSelectorProfiling))

so you should remove this check.

> Source/WebCore/inspector/InspectorCSSAgent.h:92
> +    void startSelectorProfiler(ErrorString* = 0);

0 error string would be unexpected to the method implementor.