[webkit-reviews] review denied: [Bug 73818] [Qt] Extend QQuickWebview::navigationRequested API : [Attachment 119478] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 19 05:59:51 PST 2011


Simon Hausmann <hausmann at webkit.org> has denied Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 73818: [Qt] Extend QQuickWebview::navigationRequested API
https://bugs.webkit.org/show_bug.cgi?id=73818

Attachment 119478: Patch
https://bugs.webkit.org/attachment.cgi?id=119478&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119478&action=review


Looks good in general, but there's a small memory leak that should be fixed.

> Source/WebKit2/UIProcess/qt/QtWebPagePolicyClient.cpp:105
> +    WKURLRef frameURL = WKFrameCopyURL(frame);
>      WKURLRef requestURL = WKURLRequestCopyURL(request);

Memory leak, the url refs need to be kept in RetainPtrs and adopted:

WKRetainPtr<WKURLRef> frameURL(AdoptWK, WKFrameCopyURL(frame));


More information about the webkit-reviews mailing list